Modernize collection#toArray calls#16056
Merged
vsop-479 merged 7 commits intoMay 14, 2026
Merged
Conversation
github-actions
Bot
added
module:analysis
module:core/index
module:demo
module:core/search
module:highlighter
module:benchmark
module:suggest
module:spatial
module:luke
module:facet
module:grouping
module:core/FSTs
module:queryparser
module:join
module:classification
module:test-framework
module:expressions
module:sandbox
module:spatial3d
module:misc
module:queries
labels
vsop-479
changed the title
benwtrent
approved these changes
May 13, 2026
Member
benwtrent
left a comment
benwtrent
left a comment
There was a problem hiding this comment.
seems like this should be backported to 10x as well right?
Contributor
Author
Yes, I will do it. |
vsop-479
added a commit
that referenced
this pull request
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
It looks like there were still some old-style
Collection#toArrayusages remaining after #15681 and #15833, so Copilot and I went ahead and modernized them -- except for the calls in backward-codecs.I will try to enforce a ban on old-style (or just pre-sized array style)
Collection#toArraycalls.