refactor(qdp-core): generic DataReader<T> with FloatElem#1343
Open
0lai0 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Closes #1339
Part of #1338
Changes
Why
DataReader::read_batch was hard-coded to Vec, so dtype=f32 file sources were silently promoted to f64 before encoding. That blocks a true f32 read path into encode_batch_f32. This PR parameterizes the reader traits so f32 can be added per format without another breaking API change.
How
Follow-up: impl DataReader for Parquet (and other formats as needed), plus pipeline wiring to consume Vec without casting.
Checklist