-
Notifications
You must be signed in to change notification settings - Fork 969
[docs][qdp] Add qdp development guide #732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
guan404ming
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
| uv pip install -r requirements.txt | ||
| ``` | ||
|
|
||
| If you only want to run mahout qdp without running qiskit or pennylane benchmark tests, simply uninstall them: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should clean up our environment and manage everything with uv.
We can handle this as a follow-up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure! I will create a follow-up PR for this
qdp/DEVELOPMENT.md
Outdated
|
|
||
| ### Q: I already installed CUDA driver and toolkit, making sure nvcc exists in PATH, but still get "no CUDA installed" warning | ||
|
|
||
| A: Run `cargo clean` to clean up the cache and try again No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, useful suggestion
|
Need to resolve the ci error, thanks~ |
|
Hi @guan404ming , |
| @@ -0,0 +1,90 @@ | |||
| # Development Guide | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to mention the devcontainer. #685
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this! I will add it into the docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added
| Then, go to the `benchmark/` directory, where all e2e and benchmark tests are located, and install the requirements needed for testing: | ||
|
|
||
| ```sh | ||
| uv pip install -r requirements.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm actually thinking of moving /benchmark to /qdp-python/benchmark and manage dependency with pyproject.toml in the qdp-python, and expecting to install benchmark related stuff with uv pip install '.[benchmark]' or something. What do you guys think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think is a nice suggestion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
created #735
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SG to me!
|
@machichima thanks for the patch! |
|
+1 |
|
just added qdp tag to title- we could also start using labels if y'all prefer |
|
@rich7420 added more troubleshooting. Please let me know if there's more things you want to add. Thank you! |
|
LGTM |
ryankert01
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
thanks @machichima for the patch, @guan404ming , @400Ping and @ryankert01 for the review |
Purpose of PR
Add development guide for contributors to follow
Related Issues or PRs
Changes Made
Breaking Changes
Checklist