Skip to content

Conversation

@400Ping
Copy link

@400Ping 400Ping commented Dec 17, 2025

Purpose of PR

Related Issues or PRs

Related to #712

Changes Made

  • Bug fix
  • New feature
  • Refactoring
  • Documentation
  • Test
  • CI/CD pipeline
  • Other

Breaking Changes

  • Yes
  • No

Checklist

  • Added or updated unit tests for all changes
  • Added or updated documentation for all changes
  • Successfully built and ran all unit tests or manual tests locally
  • PR title follows "MAHOUT-XXX: Brief Description" format (if related to an issue)
  • Code follows ASF guidelines

Signed-off-by: 400Ping <fourhundredping@gmail.com>
@400Ping
Copy link
Author

400Ping commented Dec 17, 2025

cc @rich7420 @guan404ming PTAL

@rich7420
Copy link
Contributor

@400Ping thanks for the patch!
could you add some comments to explain?
On the other hand, maybe we could use __ldg to improve.
refer:

const double2 vec_data = __ldg(reinterpret_cast<const double2*>(input_batch + input_base) + elem_pair);

@400Ping 400Ping mentioned this pull request Dec 18, 2025
15 tasks
Signed-off-by: 400Ping <fourhundredping@gmail.com>
@400Ping
Copy link
Author

400Ping commented Dec 22, 2025

@400Ping thanks for the patch! could you add some comments to explain? On the other hand, maybe we could use __ldg to improve. refer:

const double2 vec_data = __ldg(reinterpret_cast<const double2*>(input_batch + input_base) + elem_pair);

Done.

@rich7420
Copy link
Contributor

cc @guan404ming

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants