[QDP] refactor: introduce 2 traits for flexible io type w/ example #753
+1,233
−540
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor QDP to Support Multiple Input Types
Problem
In QDP, we had/want to support multiple input types (we now support parquet/arrow ipc, we want to add more like numpy, torch). The solution needed to:
Created a flexible, trait-based system that achieves all goals:
Core Architecture
DataReadertrait: Basic batch reading interfaceread_batch()get_sample_size()get_num_samples()StreamingDataReadertrait: Advanced streaming for large filesread_chunk()total_rows()Zero Performance Impact
into_raw_vec_and_offset)Benchmark
For reviewer
qdp/docs/readers/README.md