Skip to content

fix: fix addParentPoms=true causes repositories to be ignored. #1585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
k-wall wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −1
Open

fix: fix addParentPoms=true causes repositories to be ignored. #1585

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ...va/org/apache/maven/plugins/dependency/fromDependencies/AbstractDependencyFilterMojo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,9 +381,13 @@ private MavenProject buildProjectFromArtifact(Artifact artifact) throws MojoExec
ProjectBuildingRequest buildingRequest =
new DefaultProjectBuildingRequest(session.getProjectBuildingRequest());
buildingRequest.setProcessPlugins(false);
if (getProject().getRemoteArtifactRepositories() != null
Comment thread
slawekjaranowski marked this conversation as resolved.
Copy link
Copy Markdown
Member

@slawekjaranowski slawekjaranowski May 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getProject().getRemoteArtifactRepositories() it should be never null

&& !getProject().getRemoteArtifactRepositories().isEmpty()) {
Copy link
Copy Markdown
Member

@slawekjaranowski slawekjaranowski May 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also getProject().getRemoteArtifactRepositories() should never be empty

buildingRequest.setRemoteRepositories(getProject().getRemoteArtifactRepositories());
}
return projectBuilder.build(artifact, buildingRequest).getProject();
} catch (ProjectBuildingException e) {
throw new MojoExecutionException("Coud not build project for " + artifact.getId(), e);
throw new MojoExecutionException("Could not build project for " + artifact.getId(), e);
}
}

Expand Down
Loading