Skip to content

Fix false positive in analyze-exclusions with transitive dependency exclusion#1628

Open
slawekjaranowski wants to merge 4 commits into
apache:masterfrom
slawekjaranowski:gh-1598
Open

Fix false positive in analyze-exclusions with transitive dependency exclusion#1628
slawekjaranowski wants to merge 4 commits into
apache:masterfrom
slawekjaranowski:gh-1598

Conversation

@slawekjaranowski
Copy link
Copy Markdown
Member

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Your pull request should address just one issue, without pulling in other changes.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body.
    Note that commits might be squashed by a maintainer on merge.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
    This may not always be possible but is a best-practice.
  • Run mvn verify to make sure basic checks pass.
    A more thorough check will be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@slawekjaranowski slawekjaranowski changed the title Add IT for analyze-exclusions with transitive dependency exclusion Fix false positive in analyze-exclusions with transitive dependency exclusion May 19, 2026
@slawekjaranowski
Copy link
Copy Markdown
Member Author

Comment on lines +30 to +34
<exclusions>
<exclusion>
<groupId>org.slf4j</groupId>
<artifactId>slf4j-log4j12</artifactId>
</exclusion>
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I drop this exclusion test will fail 🤔

@slawekjaranowski slawekjaranowski marked this pull request as ready for review May 19, 2026 09:20
@slawekjaranowski slawekjaranowski requested a review from cstamas May 19, 2026 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

analyze-exclusions returns false positive unnecessary excludes

1 participant