Skip to content

Conversation

@lordgamez
Copy link
Contributor

@lordgamez lordgamez commented Oct 15, 2024

https://issues.apache.org/jira/browse/MINIFICPP-2469

Depends on #1875


Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file?
  • If applicable, have you updated the NOTICE file?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.

@lordgamez lordgamez force-pushed the MINIFICPP-2469 branch 2 times, most recently from e01554c to add4e1b Compare October 16, 2024 08:01
@lordgamez lordgamez marked this pull request as ready for review October 16, 2024 09:07
@lordgamez lordgamez force-pushed the MINIFICPP-2469 branch 2 times, most recently from 57f8862 to ef7999f Compare October 22, 2024 09:04
@lordgamez lordgamez force-pushed the MINIFICPP-2469 branch 2 times, most recently from 396e25c to 65f320f Compare October 30, 2024 09:54
@lordgamez lordgamez force-pushed the MINIFICPP-2467 branch 2 times, most recently from d2f1aed to e99afe0 Compare November 22, 2024 11:12
@szaszm szaszm closed this in ea16935 Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants