Skip to content

Conversation

@lordgamez
Copy link
Contributor

https://issues.apache.org/jira/browse/MINIFICPP-2595

Depends on #1995


Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file?
  • If applicable, have you updated the NOTICE file?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.

@lordgamez lordgamez force-pushed the MINIFICPP-2595 branch 2 times, most recently from c46ce02 to 992a13b Compare July 29, 2025 11:22
@lordgamez lordgamez force-pushed the MINIFICPP-2595 branch 2 times, most recently from a54fe4f to 266363a Compare July 30, 2025 09:06
@lordgamez lordgamez marked this pull request as ready for review July 30, 2025 11:32
@lordgamez lordgamez requested a review from Copilot August 14, 2025 11:41
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR creates a new ConvertRecord processor that converts records from one data format to another using configured Record Reader and Record Writer Controller Services. The implementation provides a standard pattern for record format conversion in the Apache NiFi MiNiFi C++ framework.

  • Implementation of a complete ConvertRecord processor with input validation and error handling
  • Comprehensive unit test coverage including success, failure, and edge cases
  • Integration test setup with controller services and feature testing

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
extensions/standard-processors/processors/ConvertRecord.h Header file defining the ConvertRecord processor class with properties, relationships, and output attributes
extensions/standard-processors/processors/ConvertRecord.cpp Implementation of the ConvertRecord processor including scheduling validation and record conversion logic
extensions/standard-processors/tests/unit/ConvertRecordTests.cpp Unit tests covering processor validation, conversion success/failure scenarios, and zero record handling
docker/test/integration/minifi/processors/ConvertRecord.py Integration test wrapper for the ConvertRecord processor
docker/test/integration/minifi/controllers/XMLReader.py Integration test wrapper for XMLReader controller service
docker/test/integration/features/steps/steps.py Step definition for setting up XMLReader controller service in integration tests
docker/test/integration/features/core_functionality.feature Integration test scenario for XML to JSON record conversion
PROCESSORS.md Documentation for the ConvertRecord processor including properties, relationships, and attributes

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

@fgerlits fgerlits closed this in ef7dbcb Sep 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants