-
Notifications
You must be signed in to change notification settings - Fork 99
MINIFICPP-2595 Create ConvertRecord processor #1996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c46ce02 to
992a13b
Compare
c2fc82c to
e6e8d8a
Compare
992a13b to
a537afe
Compare
e6e8d8a to
ff5b603
Compare
a54fe4f to
266363a
Compare
ff5b603 to
61a9e16
Compare
266363a to
539bc9b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR creates a new ConvertRecord processor that converts records from one data format to another using configured Record Reader and Record Writer Controller Services. The implementation provides a standard pattern for record format conversion in the Apache NiFi MiNiFi C++ framework.
- Implementation of a complete ConvertRecord processor with input validation and error handling
- Comprehensive unit test coverage including success, failure, and edge cases
- Integration test setup with controller services and feature testing
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
extensions/standard-processors/processors/ConvertRecord.h |
Header file defining the ConvertRecord processor class with properties, relationships, and output attributes |
extensions/standard-processors/processors/ConvertRecord.cpp |
Implementation of the ConvertRecord processor including scheduling validation and record conversion logic |
extensions/standard-processors/tests/unit/ConvertRecordTests.cpp |
Unit tests covering processor validation, conversion success/failure scenarios, and zero record handling |
docker/test/integration/minifi/processors/ConvertRecord.py |
Integration test wrapper for the ConvertRecord processor |
docker/test/integration/minifi/controllers/XMLReader.py |
Integration test wrapper for XMLReader controller service |
docker/test/integration/features/steps/steps.py |
Step definition for setting up XMLReader controller service in integration tests |
docker/test/integration/features/core_functionality.feature |
Integration test scenario for XML to JSON record conversion |
PROCESSORS.md |
Documentation for the ConvertRecord processor including properties, relationships, and attributes |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
61a9e16 to
579fd16
Compare
4a48548 to
dd252e9
Compare
78f16c6 to
12d65b4
Compare
dd252e9 to
5376b35
Compare
12d65b4 to
373020b
Compare
53e45f0 to
88ad946
Compare
9e2686c to
888ef22
Compare
88ad946 to
8c5bda0
Compare
https://issues.apache.org/jira/browse/MINIFICPP-2595
Depends on #1995
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.