MINIFICPP-2675 Move Elasticsearch tests to modular docker tests#2067
Closed
lordgamez wants to merge 2 commits intoapache:MINIFICPP-2674from
Closed
MINIFICPP-2675 Move Elasticsearch tests to modular docker tests#2067lordgamez wants to merge 2 commits intoapache:MINIFICPP-2674from
lordgamez wants to merge 2 commits intoapache:MINIFICPP-2674from
Conversation
9a3cbc2 to
53ade0b
Compare
8 tasks
12f0e18 to
25f9b07
Compare
53ade0b to
dfb597a
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR migrates Elasticsearch integration tests from the centralized docker test framework to the new modular docker test framework. The migration involves moving container management, step definitions, and test scenarios from the shared integration test infrastructure to extension-specific test modules.
- Adds new modular test infrastructure for Elasticsearch and Opensearch container management
- Updates test scenarios to use the new modular framework patterns
- Removes centralized Elasticsearch/Opensearch container and step implementations
Reviewed Changes
Copilot reviewed 16 out of 18 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| extensions/elasticsearch/tests/features/steps/steps.py | Implements step definitions for Elasticsearch/Opensearch test scenarios |
| extensions/elasticsearch/tests/features/steps/elasticsearch_container.py | Container class for managing Elasticsearch instances in tests |
| extensions/elasticsearch/tests/features/steps/opensearch_container.py | Container class for managing Opensearch instances in tests |
| extensions/elasticsearch/tests/features/steps/elastic_base_container.py | Base container class with shared functionality for both Elasticsearch and Opensearch |
| extensions/elasticsearch/tests/features/environment.py | Test environment configuration using common hooks |
| extensions/elasticsearch/tests/features/elasticsearch.feature | Updated test scenarios to use modular framework patterns |
| extensions/elasticsearch/tests/features/opensearch.feature | Updated test scenarios to use modular framework patterns |
| extensions/elasticsearch/tests/features/resources/elasticsearch.yml | Elasticsearch server configuration |
| extensions/elasticsearch/tests/features/resources/opensearch.yml | Opensearch server configuration |
| docker/test/integration/features/steps/steps.py | Removes centralized Elasticsearch/Opensearch step definitions |
| docker/test/integration/features/MiNiFi_integration_test_driver.py | Removes centralized Elasticsearch/Opensearch helper methods |
| docker/test/integration/cluster/containers/ElasticsearchContainer.py | Removed centralized container class |
| docker/test/integration/cluster/containers/OpensearchContainer.py | Removed centralized container class |
| docker/test/integration/cluster/checkers/ElasticSearchChecker.py | Removed centralized checker class |
| docker/test/integration/cluster/DockerTestCluster.py | Removes Elasticsearch/Opensearch checker references |
| docker/test/integration/cluster/ContainerStore.py | Removes Elasticsearch/Opensearch container acquisition logic |
| docker/test/integration/minifi/processors/PostElasticsearch.py | Removed centralized processor class |
| docker/RunBehaveTests.sh | Adds Elasticsearch tests to the list of extension tests to run |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
2bbcedf to
d4e290d
Compare
d4e290d to
08be6ba
Compare
25f9b07 to
e27bad6
Compare
08be6ba to
3ecc14d
Compare
szaszm
reviewed
Dec 4, 2025
Member
szaszm
left a comment
There was a problem hiding this comment.
+1 after comments are addressed from earlier PRs
fgerlits
reviewed
Dec 8, 2025
e27bad6 to
b769649
Compare
3ecc14d to
b1ee2b9
Compare
fgerlits
approved these changes
Jan 6, 2026
szaszm
approved these changes
Jan 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/MINIFICPP-2675
Depends on github.com//pull/2066
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.