-
Notifications
You must be signed in to change notification settings - Fork 99
MINIFICPP-2678 Move Grafana Loki tests to modular docker tests #2072
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: MINIFICPP-2677
Are you sure you want to change the base?
Conversation
22a74fc to
22d54f3
Compare
8a793ef to
a85a6ab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we can use this, it has no license. It will need to be deleted and reimplemented without looking at the original.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right, I was not aware of the copyright rules for github gists in case no license is defined, now I see that in this case the gist is copyrighted to the author and cannot be reused without permission. I deleted the files are rewritten them without the original source in 8cf1a6c
extensions/grafana-loki/tests/features/resources/check_log_lines_on_grafana.py
Outdated
Show resolved
Hide resolved
extensions/grafana-loki/tests/features/resources/check_log_lines_on_grafana.py
Outdated
Show resolved
Hide resolved
extensions/grafana-loki/tests/features/steps/grafana_loki_container.py
Outdated
Show resolved
Hide resolved
22d54f3 to
fd29a4b
Compare
a85a6ab to
2c819c8
Compare
2c819c8 to
8cf1a6c
Compare
https://issues.apache.org/jira/browse/MINIFICPP-2678
Depends on github.com//pull/2071
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.