Skip to content

Conversation

@fgerlits
Copy link
Contributor

Upgrade m2crypto to the latest version, to make the tests work with Python 3.13.
Plus, some minor improvements to the help string of the test runner scripts.

https://issues.apache.org/jira/browse/MINIFICPP-2697


Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

  • Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file?
  • If applicable, have you updated the NOTICE file?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.

Plus, some minor improvements to the help string of the test runner scripts.
Copy link
Member

@szaszm szaszm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

I don't know if this fixes all the issues, but I've also created a jira for fixing behave on python 3.13: MINIFICPP-2695. If this fixes all issues, then I'll close that.

@fgerlits
Copy link
Contributor Author

+1

I don't know if this fixes all the issues, but I've also created a jira for fixing behave on python 3.13: MINIFICPP-2695. If this fixes all issues, then I'll close that.

I have run the Behave tests (both old and new) locally with Python 3.13 after this change successfully. Not every extension was enabled, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants