Skip to content

MINIFICPP-2806 Fix verify package test issues#2171

Open
lordgamez wants to merge 1 commit intoapache:mainfrom
lordgamez:MINIFICPP-2806
Open

MINIFICPP-2806 Fix verify package test issues#2171
lordgamez wants to merge 1 commit intoapache:mainfrom
lordgamez:MINIFICPP-2806

Conversation

@lordgamez
Copy link
Copy Markdown
Contributor

  • Override default CA paths to use test generated root CA in tests, or leave the default CA when need external SSL communication
  • Fix minifi binary path when using RPM package

🟢 https://github.com/lordgamez/nifi-minifi-cpp/actions/runs/25425552526

https://issues.apache.org/jira/browse/MINIFICPP-2806


Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file?
  • If applicable, have you updated the NOTICE file?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.

- Override default CA paths to use test generated root CA in tests, or
  leave the default CA when need external SSL communication
- Fix minifi binary path when using RPM package
@lordgamez lordgamez added the low-impact Test only or trivial change that's most likely not gonna introduce any new bugs label May 6, 2026
@lordgamez lordgamez requested a review from Copilot May 6, 2026 09:43
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Behave-based integration test harness to fix “verify package” test failures, primarily by making system CA bundle overriding configurable (so tests that need outbound TLS can keep the distro CA store) and by adjusting how MiNiFi is launched when running from an RPM/FHS-style installation.

Changes:

  • Introduce override_default_ca_cert_files on the Behave test context, defaulting to True in the shared hooks.
  • Disable CA-bundle overriding for the Python extension feature tests so outbound HTTPS (e.g., package/download traffic) can use the image’s default CA store.
  • Update the Python examples startup command to invoke the minifi executable directly (instead of minifi.sh run), aligning with RPM/FHS layouts.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
extensions/python/tests/features/environment.py Disables default CA bundle overriding for Python feature scenarios.
behave_framework/src/minifi_behave/core/minifi_test_context.py Adds the override_default_ca_cert_files context attribute (typed).
behave_framework/src/minifi_behave/core/hooks.py Initializes override_default_ca_cert_files to True for general scenarios.
behave_framework/src/minifi_behave/containers/minifi_linux_container.py Conditionally overrides known CA bundle paths and switches Python examples launch to minifi.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

low-impact Test only or trivial change that's most likely not gonna introduce any new bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants