MINIFICPP-2806 Fix verify package test issues#2171
Open
lordgamez wants to merge 1 commit intoapache:mainfrom
Open
MINIFICPP-2806 Fix verify package test issues#2171lordgamez wants to merge 1 commit intoapache:mainfrom
lordgamez wants to merge 1 commit intoapache:mainfrom
Conversation
- Override default CA paths to use test generated root CA in tests, or leave the default CA when need external SSL communication - Fix minifi binary path when using RPM package
There was a problem hiding this comment.
Pull request overview
This PR updates the Behave-based integration test harness to fix “verify package” test failures, primarily by making system CA bundle overriding configurable (so tests that need outbound TLS can keep the distro CA store) and by adjusting how MiNiFi is launched when running from an RPM/FHS-style installation.
Changes:
- Introduce
override_default_ca_cert_fileson the Behave test context, defaulting toTruein the shared hooks. - Disable CA-bundle overriding for the Python extension feature tests so outbound HTTPS (e.g., package/download traffic) can use the image’s default CA store.
- Update the Python examples startup command to invoke the
minifiexecutable directly (instead ofminifi.sh run), aligning with RPM/FHS layouts.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| extensions/python/tests/features/environment.py | Disables default CA bundle overriding for Python feature scenarios. |
| behave_framework/src/minifi_behave/core/minifi_test_context.py | Adds the override_default_ca_cert_files context attribute (typed). |
| behave_framework/src/minifi_behave/core/hooks.py | Initializes override_default_ca_cert_files to True for general scenarios. |
| behave_framework/src/minifi_behave/containers/minifi_linux_container.py | Conditionally overrides known CA bundle paths and switches Python examples launch to minifi. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
martinzink
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🟢 https://github.com/lordgamez/nifi-minifi-cpp/actions/runs/25425552526
https://issues.apache.org/jira/browse/MINIFICPP-2806
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.