Skip to content

Conversation

@naman-shukla-ksolves
Copy link

Summary

NIFI-15393

Fixed login redirect issue where users were redirected to the home screen instead of their originally requested URL after authentication. The authentication flow now preserves the original destination URL and redirects users appropriately after login.

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-15393
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-15393

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using ./mvnw clean install -P contrib-check
    • JDK 21
    • JDK 25

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

@pvillard31 pvillard31 added the ui Pull requests for work relating to the user interface label Dec 29, 2025
Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for proposing this improvement @naman-shukla-ksolves.

From a procedural perspective, please sign all Git commits and force-push to the branch for verification.

Regarding the substantive change, I will defer to others with more perspective on the frontend, but direct reference to sessionStorage seems questionable. At minimum, having a shared service abstraction seems safer than relying on decoupled references to a common item key.

@naman-shukla-ksolves
Copy link
Author

@pvillard31 Thank you for the feedback. I've addressed both points:

  1. All Git commits are now signed and the branch has been force-pushed for verification.
  2. Replaced direct sessionStorage references with a shared service abstraction to ensure safer, decoupled state management with a single source of truth for the storage key.

Please review when you have a chance.

@naman-shukla-ksolves naman-shukla-ksolves force-pushed the NIFI-15393-fix-login-redirect branch from c989e3b to c81552f Compare December 31, 2025 08:17
… before redirecting to the login page, causing users to lose their intended destination after successful authentication
@naman-shukla-ksolves naman-shukla-ksolves force-pushed the NIFI-15393-fix-login-redirect branch from c81552f to 31b39e8 Compare December 31, 2025 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ui Pull requests for work relating to the user interface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants