NIFI-15378 Remove empty lines from formatted XML in Content Viewer #10711
+209
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-15378 Removes empty lines when rendering formatted XML in the standard Content Viewer.
The standard behavior of the JAXP Transformer is to add indentation and newlines regardless of the format of the input XML. As a result of this behavior, XML content with existing newlines is rendered with empty lines when selecting the Formatted option for XML in the Content Viewer.
Building on the discussion in PR #10679, the proposed changes implement filtering on the server for each line being written to the response stream. This approach avoids buffering large amounts of content in memory, and also avoids moving the newline replacement responsibility to the frontend.
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000VerifiedstatusPull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
./mvnw clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation