GH-3215: Make the order of encodings in column metadata deterministic#3216
Closed
handmadecode wants to merge 1 commit intoapache:masterfrom
Closed
GH-3215: Make the order of encodings in column metadata deterministic#3216handmadecode wants to merge 1 commit intoapache:masterfrom
handmadecode wants to merge 1 commit intoapache:masterfrom
Conversation
…eated by org.apache.parquet.format.converter.ParquetMetadataConverter::toFormatEncodings
Member
|
Sorry for overseeing this! Could you please rebase it to re-trigger ci? |
Contributor
Contributor
|
Merged in #3413 (review) Nevertheless, thanks @handmadecode for working on this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Two processes running the same version of parquet-java and having identical writer configurations can still produce files that are different at the binary level for the exact same written data.
What changes are included in this PR?
A single line added to
org.apache.parquet.format.converter.ParquetMetadataConverter::toFormatEncodingsAre these changes tested?
A unit test is provided. I have tested this in a custom built parquet-java with our production code for several months.
Are there any user-facing changes?
No
Closes #${3215}