Skip to content

Conversation

@tr0k
Copy link
Contributor

@tr0k tr0k commented Jan 13, 2025

This will let us be up to date with the Phoenix latest supported version as well as with latest HBase 2.5.10
This PR addresses PHOENIX-7404.

@stoty
Copy link
Contributor

stoty commented Jan 13, 2025

2.6.2 and 2.5.11 will support and and be built with Hadoop 3.4.1, I prefer to wait for that, and go to 3.4.1 directly with Phoenix.

We can upgrade to 2.5.10 now, though.

@tr0k
Copy link
Contributor Author

tr0k commented Jan 14, 2025

Hi @stoty,
Would you prefer that I adjust this contribution to focus solely on providing an updated version of HBase? For reference, I made adjustments to Hadoop following this section of the Phoenix POM.

I'm fine with updating only HBase, though I tested the new build against 3.3.6, and everything works as expected.

Additionally, I was considering adding hbase.profile.list in the same way it's implemented in the Apache Phoenix POM. Would this be a valuable addition? Maybe as part of another PR.

Looking forward to your feedback!

@stoty
Copy link
Contributor

stoty commented Jan 14, 2025

Yes, upgrading to 2.5.10 should be fine.

@stoty
Copy link
Contributor

stoty commented Jan 14, 2025

As for the profiles, I don't think that the added work of maintaining them is worth it.
The PQS binaries are not HBase version dependent, unlike Phoenix. (apart from shading bug that is already documented)

@tr0k
Copy link
Contributor Author

tr0k commented Jan 14, 2025

I have reverted the hadoop.version upgrade then. Please let me know if this can go forward now. Thank you.

@stoty
Copy link
Contributor

stoty commented Jan 15, 2025

Sorry, I got confused.

  • The Hadoop upgrade was correct, as the 5.2.1 phoenix-client maven binary is also built with 3.3.6.
  • However, this should be tracked in a new ticket for the querserver component.

Are you able to open Phoenix tickets, or should I open one for this ?

@tr0k
Copy link
Contributor Author

tr0k commented Jan 15, 2025

Hi @stoty, no problem, I just create a new ticket and a new corresponding PR: #172

Let me know if this is fine now. Cheers

@tr0k tr0k closed this Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants