Skip to content

PHOENIX-7819 HighAvailabilityGroup.URLS inner Set must be thread-safe #2437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
apurtell wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −2
Open

PHOENIX-7819 HighAvailabilityGroup.URLS inner Set must be thread-safe #2437

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions phoenix-core-client/src/main/java/org/apache/phoenix/jdbc/HighAvailabilityGroup.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
import java.sql.Driver;
import java.sql.DriverManager;
import java.sql.SQLException;
import java.util.HashSet;
import java.util.Map;
import java.util.Objects;
import java.util.Optional;
Expand Down Expand Up @@ -279,7 +278,8 @@ public static HAURLInfo getUrlInfo(String url, Properties properties) throws SQL
}
HAURLInfo haurlInfo = new HAURLInfo(name, principal, additionalJDBCParams);
HAGroupInfo info = getHAGroupInfo(url, properties);
URLS.computeIfAbsent(info, haGroupInfo -> new HashSet<>()).add(haurlInfo);
// Multiple threads can concurrently call this code path with the same HAGroupInfo.
URLS.computeIfAbsent(info, haGroupInfo -> ConcurrentHashMap.newKeySet()).add(haurlInfo);
return haurlInfo;
}

Expand Down