Skip to content

PHOENIX-7829 IndexMetadataIT.testAsyncRebuildAll filter SYSTEM.TASK queries to test's table #2446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
apurtell wants to merge 1 commit into
base: master
Choose a base branch
from
Open

PHOENIX-7829 IndexMetadataIT.testAsyncRebuildAll filter SYSTEM.TASK queries to test's table #2446

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions phoenix-core/src/it/java/org/apache/phoenix/end2end/index/IndexMetadataIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
package org.apache.phoenix.end2end.index;

import static org.apache.phoenix.exception.SQLExceptionCode.CANNOT_SET_OR_ALTER_UPDATE_CACHE_FREQ_FOR_INDEX;
import static org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.TABLE_NAME;
import static org.apache.phoenix.query.QueryServicesOptions.DEFAULT_UPDATE_CACHE_FREQUENCY;
import static org.apache.phoenix.util.TestUtil.INDEX_DATA_SCHEMA;
import static org.apache.phoenix.util.TestUtil.TEST_PROPERTIES;
Expand Down Expand Up @@ -750,8 +749,11 @@ public void testAsyncRebuildAll() throws Exception {
conn.createStatement()
.execute("ALTER INDEX " + indexName + " ON " + testTable + " REBUILD ALL ASYNC");

String taskFilter = " WHERE " + PhoenixDatabaseMetaData.TASK_TYPE + " = "
+ PTable.TaskType.INDEX_REBUILD.getSerializedValue() + " AND "
+ PhoenixDatabaseMetaData.TABLE_NAME + " = '" + testTable + "'";
ResultSet resultSet = conn.createStatement()
.executeQuery("SELECT * FROM " + PhoenixDatabaseMetaData.SYSTEM_TASK_NAME);
.executeQuery("SELECT * FROM " + PhoenixDatabaseMetaData.SYSTEM_TASK_NAME + taskFilter);
assertTrue(resultSet.next());
assertEquals("2", resultSet.getString(1));
assertNull(resultSet.getString(3));
Expand All @@ -761,11 +763,7 @@ public void testAsyncRebuildAll() throws Exception {
assertEquals("4", resultSet.getString(8));
assertEquals("{\"IndexName\":\"" + indexName + "\",\"RebuildAll\":true}",
resultSet.getString(9));
String queryTaskTable = "SELECT * FROM " + PhoenixDatabaseMetaData.SYSTEM_TASK_NAME;
ResultSet rs = conn.createStatement().executeQuery(queryTaskTable);
assertTrue(rs.next());
assertEquals(testTable, rs.getString(TABLE_NAME));
assertFalse(rs.next());
assertFalse(resultSet.next());

TestUtil.waitForIndexState(conn, indexName, PIndexState.ACTIVE);

Expand All @@ -775,7 +773,7 @@ public void testAsyncRebuildAll() throws Exception {
+ PTable.TaskType.INDEX_REBUILD.getSerializedValue() + " AND "
+ PhoenixDatabaseMetaData.TABLE_NAME + " = '" + testTable + "'";

rs = conn.createStatement().executeQuery(query);
ResultSet rs = conn.createStatement().executeQuery(query);
assertTrue(rs.next());
String taskStatus = rs.getString(PhoenixDatabaseMetaData.TASK_STATUS);
assertEquals(PTable.TaskStatus.COMPLETED.toString(), taskStatus);
Expand Down