Skip to content

PHOENIX-7834 CDCBaseIT do not force-delete a never-upserted row #2451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
apurtell wants to merge 1 commit into
base: master
Choose a base branch
from
Open

PHOENIX-7834 CDCBaseIT do not force-delete a never-upserted row #2451

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions phoenix-core/src/it/java/org/apache/phoenix/end2end/CDCBaseIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,8 +332,12 @@ protected List<Set<ChangeRow>> generateMutations(String tenantId, long startTS,
for (int j = 0; j < nRows; ++j) {
if (rand.nextInt(nRows) % 2 == 0) {
boolean isDelete;
if (i > nBatches / 2 && !gotDelete) {
// Force a delete if there was none so far.
// Only force a delete on rows that have already been upserted in this run; deleting a
// never-inserted row produces a no-op tombstone on the data table while CDC still
// surfaces a later upsert for the same key, deterministically tripping the
// delete-vs-upsert assertion in verifyChangesViaSCN. If no candidate exists yet, defer
// the forced delete to a later batch (the loop will reconsider on the next iteration).
if (i > nBatches / 2 && !gotDelete && mutatedRows.contains(rows.get(j))) {
isDelete = true;
} else {
isDelete = mutatedRows.contains(rows.get(j)) && rand.nextInt(5) == 0;
Expand Down