Skip to content

PHOENIX-7840 UpdateCacheIT recategorize as NeedsOwnMiniClusterTest #2457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
apurtell wants to merge 1 commit into
base: master
Choose a base branch
from
+18 −2
Open

PHOENIX-7840 UpdateCacheIT recategorize as NeedsOwnMiniClusterTest #2457

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions phoenix-core/src/it/java/org/apache/phoenix/rpc/UpdateCacheIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@
import java.util.concurrent.Executors;
import java.util.concurrent.TimeUnit;
import java.util.concurrent.atomic.AtomicBoolean;
import org.apache.phoenix.end2end.NeedsOwnMiniClusterTest;
import org.apache.phoenix.end2end.ParallelStatsDisabledIT;
import org.apache.phoenix.end2end.ParallelStatsDisabledTest;
import org.apache.phoenix.jdbc.PhoenixDatabaseMetaData;
import org.apache.phoenix.jdbc.PhoenixEmbeddedDriver;
import org.apache.phoenix.query.ConnectionQueryServices;
Expand All @@ -66,8 +66,24 @@
/**
* Verifies the number of RPC calls from {@link MetaDataClient} updateCache() for transactional and
* non-transactional tables.
*
* <p>Categorized as {@link NeedsOwnMiniClusterTest} so failsafe runs this class in its own forked
* JVM (reuseForks=false). The {@link #helpTestUpdateCache} helper wraps the JVM-singleton
* {@link ConnectionQueryServices} returned by {@code driver.getConnectionQueryServices(...)} in a
* Mockito spy. Because the Phoenix driver caches that CQS as a process-global singleton and the
* spy delegates to the real instance with {@code this} bound to the spy, every internal Phoenix
* call back through the services field is recorded in the spy's {@code InvocationContainerImpl},
* holding strong references to all arguments. Under the {@code ParallelStatsDisabledTest}
* execution ({@code reuseForks=true}) this class previously ran in a fork that had already
* accumulated thousands of tests' worth of cached metadata, regions, and live ZK clients on the
* same singleton; combined with the spy's invocation-history retention, the fork was tipping over
* with {@code OutOfMemoryError: Java heap space} (5.8 GB heap dump from the ZK
* {@code main-SendThread}) on {@link #testUpdateCacheForNonTxnTable}. Running in its own JVM
* gives the test a fresh CQS singleton with no cross-test accumulation. This follows the same
* convention as {@code MetaDataEndPointIT} and other singleton-state-sensitive tests in this
* project.
*/
@Category(ParallelStatsDisabledTest.class)
@Category(NeedsOwnMiniClusterTest.class)
public class UpdateCacheIT extends ParallelStatsDisabledIT {

private boolean isLastDDLTimestampValidationEnabled =
Expand Down