Skip to content

Conversation

@lhotari
Copy link
Member

@lhotari lhotari commented Jan 16, 2026

Motivation

The Jetty 12 upgrade PR #25100 patches ZooKeeper by upgrading from Jetty 9 to Jetty 12. This patching uses a shaded jar without really shading packages, but just replacing a single package.
This solution breaks IntelliJ build since the pom.xml is missing required definitions for IntelliJ Maven integration with shaded jars. When the IntelliJ build is broken, it's not possible to run all tests in the IntelliJ UI.

Modifications

  • add definitions to pom.xml required for IntelliJ Maven integration

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@lhotari lhotari added this to the 4.2.0 milestone Jan 16, 2026
@lhotari lhotari self-assigned this Jan 16, 2026
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jan 16, 2026
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.62%. Comparing base (0d5358a) to head (ee8cd60).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             master   #25155       +/-   ##
=============================================
+ Coverage     37.28%   72.62%   +35.33%     
- Complexity    13112    33746    +20634     
=============================================
  Files          1899     1956       +57     
  Lines        150565   154740     +4175     
  Branches      17156    17644      +488     
=============================================
+ Hits          56134   112373    +56239     
+ Misses        86744    33402    -53342     
- Partials       7687     8965     +1278     
Flag Coverage Δ
inttests 25.66% <ø> (-0.01%) ⬇️
systests 22.49% <ø> (+0.01%) ⬆️
unittests 73.56% <ø> (+39.66%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1423 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lhotari lhotari merged commit f5fc992 into apache:master Jan 16, 2026
98 of 101 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/build doc-not-needed Your PR changes do not impact docs ready-to-test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants