Skip to content

[fix][client] Fix OpenTelemetryProducerInterceptor not executing due to eligible check #25585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hrzzzz wants to merge 3 commits into
base: master
Choose a base branch
from
+26 −26
Open

[fix][client] Fix OpenTelemetryProducerInterceptor not executing due to eligible check #25585

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4abe3bd
[fix][client] Fix OpenTelemetryProducerInterceptor not executing due …
Apr 27, 2026
6e76b9f
fix typo
May 7, 2026
88d6e7f
fix
May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 24 additions & 24 deletions ...r/src/test/java/org/apache/pulsar/broker/service/OpenTelemetryTracingIntegrationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,33 +128,30 @@ public void testBasicProducerConsumerTracing() throws Exception {
// Force flush tracer provider
flushSpans();

// Verify spans - at least one span should be created
// Verify spans - expected 2 spans to be created
List<SpanData> spans = spanExporter.getFinishedSpanItems();
assertTrue(spans.size() > 0, "Expected at least one span, got: " + spans.size());
assertEquals(spans.size(), 2, "Expected 2 spans, got: " + spans.size());

// Verify producer span if present
spans.stream()
// Verify producer span
SpanData producerSpan = spans.stream()
.filter(s -> s.getKind() == SpanKind.PRODUCER)
.findFirst()
.ifPresent(producerSpan -> {
assertEquals(producerSpan.getName(), "send " + topic);
assertEquals(producerSpan.getAttributes().get(
io.opentelemetry.api.common.AttributeKey.stringKey("messaging.system")), "pulsar");
});
.orElseThrow();
assertEquals(producerSpan.getName(), "send " + topic);
assertEquals(producerSpan.getAttributes().get(
io.opentelemetry.api.common.AttributeKey.stringKey("messaging.system")), "pulsar");

// Verify consumer span if present
spans.stream()
// Verify consumer span
SpanData consumerSpan = spans.stream()
.filter(s -> s.getKind() == SpanKind.CONSUMER)
.findFirst()
.ifPresent(consumerSpan -> {
assertEquals(consumerSpan.getName(), "process " + topic);
assertEquals(consumerSpan.getAttributes().get(
io.opentelemetry.api.common.AttributeKey.stringKey("messaging.system")), "pulsar");
assertEquals(consumerSpan.getAttributes().get(
io.opentelemetry.api.common.AttributeKey.stringKey(
"messaging.pulsar.acknowledgment.type")),
"acknowledge");
});
.orElseThrow();
assertEquals(consumerSpan.getName(), "process " + topic);
assertEquals(consumerSpan.getAttributes().get(
io.opentelemetry.api.common.AttributeKey.stringKey("messaging.system")), "pulsar");
assertEquals(consumerSpan.getAttributes().get(
io.opentelemetry.api.common.AttributeKey.stringKey("messaging.pulsar.acknowledgment.type")),
"acknowledge");
}

@Test
Expand Down Expand Up @@ -720,14 +717,16 @@ public void testBatchMessagesTracing() throws Exception {
.subscriptionName("test-sub")
.subscribe();

int numMessages = 5;

// Send batch of messages
for (int i = 0; i < 5; i++) {
for (int i = 0; i < numMessages; i++) {
producer.sendAsync("message-" + i);
}
producer.flush();

// Receive and acknowledge all messages
for (int i = 0; i < 5; i++) {
for (int i = 0; i < numMessages; i++) {
Message<String> msg = consumer.receive(5, TimeUnit.SECONDS);
assertNotNull(msg);
consumer.acknowledge(msg);
Expand All @@ -741,9 +740,10 @@ public void testBatchMessagesTracing() throws Exception {
flushSpans();

// Verify spans for batched messages
// Note: Tracing behavior may vary for batched messages depending on when spans are created
List<SpanData> spans = spanExporter.getFinishedSpanItems();
assertTrue(spans.size() > 0, "Expected at least some spans for batched messages");
int expectedNumSpans = numMessages * 2;
assertEquals(spans.size(), expectedNumSpans,
"Expected " + expectedNumSpans + " spans for batched messages, got " + spans.size());

// Verify that spans have correct attributes
spans.stream()
Expand Down
4 changes: 2 additions & 2 deletions ...src/main/java/org/apache/pulsar/client/impl/tracing/OpenTelemetryProducerInterceptor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,15 +77,15 @@ public void close() {

@Override
public boolean eligible(Message<?> message) {
return tracer != null && propagator != null;
return true;
}

@Override
public Message<?> beforeSend(Producer<?> producer, Message<?> message) {
// Initialize tracer from producer on first call
initializeIfNeeded(producer);

if (!eligible(message)) {
if (tracer == null || propagator == null) {
return message;
}

Expand Down