Skip to content

[ISSUE #10161] reduce bytes copy #10233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ChineseTony wants to merge 1 commit into from
Closed

[ISSUE #10161] reduce bytes copy #10233

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion broker/src/main/java/org/apache/rocketmq/broker/config/v1/RocksDBConfigManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ public void delete(final byte[] keyBytes) throws Exception {
public void updateKvDataVersion() throws Exception {
kvDataVersion.nextVersion();
this.configRocksDBStorage.put(versionCF, KV_DATA_VERSION_KEY, KV_DATA_VERSION_KEY.length,
JSON.toJSONString(kvDataVersion).getBytes(StandardCharsets.UTF_8));
JSON.toJSONBytes(kvDataVersion, StandardCharsets.UTF_8));
}

public DataVersion getKvDataVersion() {
Expand Down
2 changes: 1 addition & 1 deletion broker/src/main/java/org/apache/rocketmq/broker/processor/AckMessageProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,7 @@ private void appendAck(final AckMessageRequestHeader requestHeader, final BatchA

MessageExtBrokerInner msgInner = new MessageExtBrokerInner();
msgInner.setTopic(reviveTopic);
msgInner.setBody(JSON.toJSONString(ackMsg).getBytes(StandardCharsets.UTF_8));
msgInner.setBody(JSON.toJSONBytes(ackMsg, StandardCharsets.UTF_8));
msgInner.setQueueId(rqId);
if (ackMsg instanceof BatchAckMsg) {
msgInner.setTags(PopAckConstants.BATCH_ACK_TAG);
Expand Down
4 changes: 2 additions & 2 deletions broker/src/main/java/org/apache/rocketmq/broker/processor/AdminBrokerProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3195,7 +3195,7 @@ private RemotingCommand getUser(ChannelHandlerContext ctx,
response.setCode(ResponseCode.SUCCESS);
if (user != null) {
UserInfo userInfo = UserConverter.convertUser(user);
response.setBody(JSON.toJSONString(userInfo).getBytes(StandardCharsets.UTF_8));
response.setBody(JSON.toJSONBytes(userInfo, StandardCharsets.UTF_8));
}
})
.exceptionally(ex -> {
Expand All @@ -3218,7 +3218,7 @@ private RemotingCommand listUser(ChannelHandlerContext ctx,
response.setCode(ResponseCode.SUCCESS);
if (CollectionUtils.isNotEmpty(users)) {
List<UserInfo> userInfos = UserConverter.convertUsers(users);
response.setBody(JSON.toJSONString(userInfos).getBytes(StandardCharsets.UTF_8));
response.setBody(JSON.toJSONBytes(userInfos, StandardCharsets.UTF_8));
}
})
.exceptionally(ex -> {
Expand Down
4 changes: 2 additions & 2 deletions broker/src/main/java/org/apache/rocketmq/broker/processor/ChangeInvisibleTimeProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,7 @@ private CompletableFuture<Boolean> ackOrigin(final ChangeInvisibleTimeRequestHea
}

msgInner.setTopic(reviveTopic);
msgInner.setBody(JSON.toJSONString(ackMsg).getBytes(StandardCharsets.UTF_8));
msgInner.setBody(JSON.toJSONBytes(ackMsg, StandardCharsets.UTF_8));
msgInner.setQueueId(rqId);
msgInner.setTags(PopAckConstants.ACK_TAG);
msgInner.setBornTimestamp(System.currentTimeMillis());
Expand Down Expand Up @@ -326,7 +326,7 @@ private CompletableFuture<Boolean> appendCheckPointThenAckOrigin(
ck.setBrokerName(ExtraInfoUtil.getBrokerName(extraInfo));
ck.setSuspend(requestHeader.isSuspend());

msgInner.setBody(JSON.toJSONString(ck).getBytes(StandardCharsets.UTF_8));
msgInner.setBody(JSON.toJSONBytes(ck, StandardCharsets.UTF_8));
msgInner.setQueueId(reviveQid);
msgInner.setTags(PopAckConstants.CK_TAG);
msgInner.setBornTimestamp(System.currentTimeMillis());
Expand Down
2 changes: 1 addition & 1 deletion broker/src/main/java/org/apache/rocketmq/broker/processor/PopMessageProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -942,7 +942,7 @@ public MessageExtBrokerInner buildCkMsg(final PopCheckPoint ck, final int revive
MessageExtBrokerInner msgInner = new MessageExtBrokerInner();

msgInner.setTopic(reviveTopic);
msgInner.setBody(JSON.toJSONString(ck).getBytes(StandardCharsets.UTF_8));
msgInner.setBody(JSON.toJSONBytes(ck, StandardCharsets.UTF_8));
msgInner.setQueueId(reviveQid);
msgInner.setTags(PopAckConstants.CK_TAG);
msgInner.setBornTimestamp(System.currentTimeMillis());
Expand Down
2 changes: 1 addition & 1 deletion ...c/main/java/org/apache/rocketmq/proxy/service/sysmessage/AbstractSystemMessageSyncer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ protected void sendSystemMessage(Object data) {
try {
Message message = new Message(
targetTopic,
JSON.toJSONString(data).getBytes(StandardCharsets.UTF_8)
JSON.toJSONBytes(data, StandardCharsets.UTF_8)
);

AddressableMessageQueue messageQueue = this.topicRouteService.getAllMessageQueueView(ProxyContext.createForInner(this.getClass()), targetTopic)
Expand Down
Loading