Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion WORKSPACE
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ load("@rules_jvm_external//:defs.bzl", "maven_install")
maven_install(
artifacts = [
"junit:junit:4.13.2",
"com.alibaba:fastjson:1.2.76",
"com.alibaba.fastjson2:fastjson2:2.0.59",
"org.hamcrest:hamcrest-library:1.3",
"io.netty:netty-all:4.1.65.Final",
Expand Down
4 changes: 0 additions & 4 deletions common/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,6 @@
</properties>

<dependencies>
<dependency>
<groupId>com.alibaba</groupId>
<artifactId>fastjson</artifactId>
</dependency>
<dependency>
<groupId>com.alibaba.fastjson2</groupId>
<artifactId>fastjson2</artifactId>
Expand Down
6 changes: 0 additions & 6 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,6 @@
<netty.version>4.1.130.Final</netty.version>
<netty.tcnative.version>2.0.53.Final</netty.tcnative.version>
<bcpkix-jdk18on.version>1.83</bcpkix-jdk18on.version>
<fastjson.version>1.2.83</fastjson.version>
<fastjson2.version>2.0.59</fastjson2.version>
<javassist.version>3.20.0-GA</javassist.version>
<jna.version>4.2.2</jna.version>
Expand Down Expand Up @@ -689,11 +688,6 @@
<type>jar</type>
<version>${bcpkix-jdk18on.version}</version>
</dependency>
<dependency>
<groupId>com.alibaba</groupId>
<artifactId>fastjson</artifactId>
<version>${fastjson.version}</version>
</dependency>
<dependency>
<groupId>com.alibaba.fastjson2</groupId>
<artifactId>fastjson2</artifactId>
Expand Down
1 change: 0 additions & 1 deletion remoting/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@ java_library(
"//common",
"//:test_deps",
"@maven//:org_objenesis_objenesis",
"@maven//:com_alibaba_fastjson",
"@maven//:com_alibaba_fastjson2_fastjson2",
"@maven//:com_google_code_gson_gson",
"@maven//:com_google_guava_guava",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,11 @@

package org.apache.rocketmq.remoting.protocol;

import com.alibaba.fastjson.annotation.JSONField;
import com.alibaba.fastjson2.annotation.JSONField;
import com.alibaba.fastjson2.JSON;
import org.apache.rocketmq.remoting.protocol.body.BatchAck;
import org.junit.Test;
import org.objenesis.ObjenesisStd;
import org.reflections.Reflections;

import java.lang.reflect.Array;
import java.lang.reflect.Field;
Expand All @@ -41,34 +40,8 @@
import java.util.concurrent.atomic.AtomicLong;

import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertTrue;

public class RemotingSerializableCompatTest {

@Test
public void testCompatibilityCheck() {
Reflections reflections = new Reflections("org.apache.rocketmq.remoting.protocol");
Set<Class<? extends RemotingSerializable>> subTypes = reflections.getSubTypesOf(RemotingSerializable.class);

for (Class<? extends RemotingSerializable> clazz : subTypes) {
if (clazz.isInterface() || Modifier.isAbstract(clazz.getModifiers()) || clazz.getSimpleName().endsWith("Test")
|| clazz.isAnonymousClass() || clazz.getName().contains("$")) {
continue;
}
try {
RemotingSerializable instance;
try {
instance = clazz.getDeclaredConstructor().newInstance();
} catch (NoSuchMethodException e) {
instance = allocateInstance(clazz);
}
fillDefaultFields(instance, clazz);
assertTrue(checkCompatible(instance, clazz));
} catch (Exception e) {
System.err.printf("Class %s: incompatible, error: %s\n", clazz.getName(), e.getMessage());
}
}
}

@Test
public void testCompatibilityCheckWithBitSet() {
Expand Down Expand Up @@ -406,19 +379,7 @@ private boolean isPrimitiveOrWrapper(final Class<?> clazz) {
clazz == Float.class ||
clazz == Double.class;
}

private boolean checkCompatible(final Object original, final Class<?> clazz) {
String json = com.alibaba.fastjson.JSON.toJSONString(original);
Object deserialized;
try {
deserialized = com.alibaba.fastjson2.JSON.parseObject(json, clazz);
} catch (Exception e) {
System.err.printf("Deserialization failed for %s: %s\n", clazz.getName(), e.getMessage());
return false;
}
return checkCompatible(original, deserialized, clazz.getSimpleName(), new HashMap<>());
}


private <T> T allocateInstance(final Class<T> clazz) {
return new ObjenesisStd().newInstance(clazz);
}
Expand Down
Loading