Skip to content

chore: add branch protection rules#2701

Open
lprimak wants to merge 1 commit into
apache:mainfrom
lprimak:add-branch-protection
Open

chore: add branch protection rules#2701
lprimak wants to merge 1 commit into
apache:mainfrom
lprimak:add-branch-protection

Conversation

@lprimak
Copy link
Copy Markdown
Contributor

@lprimak lprimak commented May 13, 2026

This is the response to ASF Infra's security tightening initiative.

Following this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GitHub issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a GitHub issue. Your pull request should address just this issue, without pulling in other changes.
  • Format the pull request title like [#XXX] - Fixes bug in SessionManager,
    where you replace #XXX with the appropriate GitHub issue. Best practice
    is to use the GitHub issue title in the pull request title and in the first line of the commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • add fixes #XXX if merging the PR should close a related issue.
  • Run mvn verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • Committers: Make sure a milestone is set on the PR
  • Committers: Use "Squash and Merge" to combine all commits into one when merging a PR when appropriate.

Trivial changes like typos do not require a GitHub issue (javadoc, comments...).
In this case, just format the pull request title like [DOC] - Add javadoc in SessionManager.

If this is your first contribution, you have to read the Contribution Guidelines

If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement
if you are unsure please ask on the developers list.

To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@github-actions github-actions Bot added the yaml label May 13, 2026
@lprimak lprimak requested a review from bmarwell May 20, 2026 20:41
Copy link
Copy Markdown
Contributor

@bmarwell bmarwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

require_last_push_approval: false
require_code_owner_reviews: false
required_approving_review_count: 0

I wish we could to true, true, 1. But I see that is currently not possible, so... works for me!

        includes:
          - "main"
          - "release/*"

I haven't seen any other maintenance branch we would need to include. So, works for me (but please double check)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants