Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds centralized SkyWalking OAP URL normalization/validation and enforces it at transport command startup to fail fast on unsupported URL schemes.
Changes:
- Introduces
tools.NormalizeOAPURL()to finalize the GraphQL endpoint and validate allowed URL schemes. - Adds
validateConfiguredSkyWalkingURL()and calls it fromstdio,sse, andstreamablecommand entrypoints. - Adds unit tests covering URL normalization and invalid scheme rejection across transports.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| internal/tools/common.go | Adds NormalizeOAPURL wrapper to finalize URL and validate scheme. |
| internal/tools/common_test.go | Adds tests for NormalizeOAPURL including unsupported scheme coverage. |
| internal/swmcp/server.go | Uses NormalizeOAPURL for configured URL + adds shared validation helper. |
| internal/swmcp/stdio.go | Fails fast on invalid configured SkyWalking URL before starting stdio server. |
| internal/swmcp/sse.go | Fails fast on invalid configured SkyWalking URL before starting SSE server. |
| internal/swmcp/streamable.go | Fails fast on invalid configured SkyWalking URL before starting Streamable server. |
| internal/swmcp/server_test.go | Adds tests ensuring invalid schemes are rejected by validation and transport commands. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
wu-sheng
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.