Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR optimizes the release workflow by producing a source tarball from Git-tracked files only and reducing the SVN working copy scope to the mcp subtree for candidate uploads.
Changes:
- Build binaries with explicit
VERSIONandGIT_COMMITpassed through the release script. - Generate the source tarball via
git archiveinto a staging dir, adding a.envwithRELEASE_VERSION. - Narrow SVN checkout/upload path to
https://dist.apache.org/repos/dist/dev/skywalking/mcp/and update release docs accordingly.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| scripts/release.sh | Passes release metadata into the build and switches source packaging to git archive + staged .env. |
| scripts/push-release.sh | Checks out only the mcp SVN subtree and adjusts copy/commit paths. |
| RELEASE.md | Updates the documented SVN checkout URL and destination paths. |
| Makefile | Loads .env and makes VERSION/GIT_COMMIT resolution more robust when Git metadata is unavailable. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
wu-sheng
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR tightens the release flow by reducing the source package to release relevant files only and narrowing the SVN upload working copy to the mcp directory.
Signed-off-by: Qiuxia Fan qiuxiafan@apache.org