[SPARK-55065] Avoid making two JDBC API calls #53830
Closed
+18
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JIRA Issue Information=== Improvement SPARK-55065 === This comment was automatically generated by GitHub Actions |
SavicStefan
changed the title
urosstan-db
reviewed
Jan 16, 2026
...ore/src/main/scala/org/apache/spark/sql/execution/datasources/v2/jdbc/JDBCTableCatalog.scala
Outdated
Show resolved
Hide resolved
urosstan-db
reviewed
Jan 16, 2026
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala
Show resolved
Hide resolved
urosstan-db
reviewed
Jan 16, 2026
| * | ||
| * @return A StructType giving the table's Catalyst schema. | ||
| * @throws java.sql.SQLException if the table specification is garbage. | ||
| * @throws java.sql.SQLException if the table contains an unsupported type. |
Contributor
There was a problem hiding this comment.
Can you add new params to docs, including conn?
cloud-fan
reviewed
Jan 16, 2026
...rc/test/scala/org/apache/spark/sql/execution/datasources/v2/jdbc/JDBCTableCatalogSuite.scala
Outdated
Show resolved
Hide resolved
urosstan-db
approved these changes
Jan 19, 2026
cloud-fan
approved these changes
Jan 19, 2026
Contributor
|
thanks, merging to master! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Instead of explicitly calling
tableExistsinJDBCTableCatalog.loadTable(...), this change now detects whether a table exists by catchingSQLExceptionfromgetQueryOutputSchemaand checking it with the dialect-specificisObjectNotFoundExceptionmethod.By checking
isObjectNotFoundExceptionbeforeisSyntaxErrorBestEffort, the code can reliably distinguish between the case where table does not exists and other SQL syntax errors. This order is important because when a table does not exist, the exception raised can also match the criteria forisSyntaxErrorBestEffort.Why are the changes needed?
This change removes the redundant tableExists call, since we can determine whether a table exists based on the error thrown from
getQueryOutputSchema.With this change now only makes one JDBC API call instead of two, improving efficiency by eliminating the need for a separate table existence check.
Does this PR introduce any user-facing change?
No
How was this patch tested?
It was tested using existing and new tests in
JDBCTableCatalogSuite.Was this patch authored or co-authored using generative AI tooling?
No.