[SYSTEMDS-3891] New out-of-core instructions and improvements / bugfixes#2362
Closed
janniklinde wants to merge 2 commits into
Closed
[SYSTEMDS-3891] New out-of-core instructions and improvements / bugfixes#2362janniklinde wants to merge 2 commits into
janniklinde wants to merge 2 commits into
Conversation
e8f6f2c to
a681204
Compare
1149d1f to
a0fdc7f
Compare
a0fdc7f to
dd0d7f2
Compare
Contributor
Author
|
Removed the invalid blocksize propagation which I added for completeness. Now the io tests should pass @mboehm7 |
Contributor
Author
|
Re-ran the failing tests locally but could not reproduce |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2362 +/- ##
============================================
- Coverage 72.33% 72.28% -0.05%
- Complexity 46909 46933 +24
============================================
Files 1513 1513
Lines 178198 178429 +231
Branches 34984 35037 +53
============================================
+ Hits 128902 128982 +80
- Misses 39545 39681 +136
- Partials 9751 9766 +15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
LGTM - thanks @janniklinde. Sometimes, there are spurious failures and we have to trigger these tests again. During the merge, I only removed some unused variables from the OOC datagen instruction. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds new out-of-core instructions such as
rand(only constant support usingmatrix(v, ...)) andrsort, which are required for builtin PCA. Further, the patch adds support for broadcasting binary operations (on matrices where dimensions are known) and improves performance for TSMM by enabling parallel processing. Finally, bugfixes are provided forCachingStream(fixing error propagation), forDataOp(to propagate dimensions in the HOP DAG when havingTeenodes), and forMatrixObject(to supportacquireReadon unknown dimensions).