Skip to content

THRIFT-5947: Fix JavaScript exception constructor implementation (ES6) #3372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jens-G merged 1 commit into from
Apr 8, 2026
+2 −1
Merged

THRIFT-5947: Fix JavaScript exception constructor implementation (ES6) #3372

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion compiler/cpp/src/thrift/generate/t_js_generator.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -950,7 +950,8 @@ void t_js_generator::generate_js_struct_definition(ostream& out,
// Call super() method on inherited Error class
if (gen_node_ && is_exception) {
if (gen_es6_) {
indent(out) << "super(args);" << '\n';
indent(out) << "super(\"" << js_namespace(tstruct->get_program())
<< tstruct->get_name() << "\");" << '\n';
} else {
indent(out) << "Thrift.TException.call(this, \"" << js_namespace(tstruct->get_program())
<< tstruct->get_name() << "\");" << '\n';
Expand Down
Loading