Skip to content

Add additional unit tests for compute and computeIfAbsent in ParameterMap #958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
YCharanGowda wants to merge 3 commits into
base: main
Choose a base branch
from
+27 −1
Open

Add additional unit tests for compute and computeIfAbsent in ParameterMap #958

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8753511
Improve sentence in README for clarity
Mar 10, 2026
b52d802
Add additional unit tests for compute and computeIfAbsent in Paramete…
Mar 14, 2026
5bcefdf
Merge branch 'main' into charan-first-contribution
YCharanGowda Mar 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 27 additions & 1 deletion test/org/apache/catalina/util/TestParameterMap.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,11 +300,37 @@ public void testEntrySetImmutabilityAfterLocked() {
Assert.fail("ParameterMap is not locked.");
} catch (UnsupportedOperationException expectedException) {
}

try {
entrySet.clear();
Assert.fail("ParameterMap is not locked.");
} catch (UnsupportedOperationException expectedException) {
}
}
@Test
public void testComputeIfAbsentAfterLocked() {
((ParameterMap<String, String[]>) paramMap).setLocked(true);

try {
paramMap.computeIfAbsent("param5", k -> new String[]{"value5"});
Assert.fail("ParameterMap is not locked.");
} catch (IllegalStateException expectedException) {
}
}

@Test
public void testComputeAfterLocked() {
((ParameterMap<String, String[]>) paramMap).setLocked(true);

try {
paramMap.compute("param1", (k, v) -> new String[]{"changed"});
Assert.fail("ParameterMap is not locked.");
} catch (IllegalStateException expectedException) {
}
}

@Test
public void testEmptyParameterMap() {
Map<String,String[]> map = new ParameterMap<>();
Assert.assertTrue(map.isEmpty());
}
}