Fix prev_is_cr flag handling in chunked encoding parser#13036
Open
bryancall wants to merge 1 commit intoapache:masterfrom
Open
Fix prev_is_cr flag handling in chunked encoding parser#13036bryancall wants to merge 1 commit intoapache:masterfrom
bryancall wants to merge 1 commit intoapache:masterfrom
Conversation
The prev_is_cr flag in ChunkedHandler::read_size() was being set within conditional expressions but not consistently updated, which could cause it to retain stale values across parsing iterations. Update the flag at the end of each loop iteration to ensure it accurately reflects the current character state. This improves the correctness of line break validation when parsing chunked transfer encoding with strict_chunk_parsing enabled.
This was referenced Mar 30, 2026
Contributor
Author
|
[approve ci autest 2] |
cmcfarlen
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
prev_is_crflag inChunkedHandler::read_size()was being set within conditional expressions but not consistently updated, which could cause it to retain stale values across parsing iterations.This change updates the flag at the end of each loop iteration to ensure it accurately reflects the current character state. This improves the correctness of line break validation when parsing chunked transfer encoding with
strict_chunk_parsingenabled.Changes
prev_is_crin conditionalsprev_is_crat end of loop iterationTesting