Add a method to batch search for the MetadataIndexNode offset of devices#550
Open
shuwenwei wants to merge 18 commits intoapache:developfrom
Open
Add a method to batch search for the MetadataIndexNode offset of devices#550shuwenwei wants to merge 18 commits intoapache:developfrom
shuwenwei wants to merge 18 commits intoapache:developfrom
Conversation
JackieTien97
requested changes
Jul 23, 2025
| * array size is 2, the first element is the start offset, and the second is the end offset | ||
| * @throws IOException io error | ||
| */ | ||
| public long[][] getDeviceMetadataIndexNodeOffsets( |
Contributor
There was a problem hiding this comment.
using long[] may be better for memory consumption?
|
|
||
| public class MetadataIndexNode { | ||
|
|
||
| private static final double LOG2 = Math.log(2); |
Contributor
There was a problem hiding this comment.
what's this magic number used for?
Member
Author
There was a problem hiding this comment.
Used for calculating complexity, it will select the search method according to the complexity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For a tsfile with 80,000 devices, the time to read metadata can be reduced from 4.5s to 500ms.