Skip to content

add 'dataTypeModifiedAndCannotUseStatistics'#724

Merged
JackieTien97 merged 4 commits intoapache:developfrom
shuwenwei:fixSetModified-0206
Feb 6, 2026
Merged

add 'dataTypeModifiedAndCannotUseStatistics'#724
JackieTien97 merged 4 commits intoapache:developfrom
shuwenwei:fixSetModified-0206

Conversation

@shuwenwei
Copy link
Member

Purpose

  • Ensure the "data type modified" state that prevents using statistics is propagated from time series metadata down to chunk metadata and is considered when deciding whether metadata is "modified".
  • Fix lost/ignored data-type-modified information when metadata is copied or passed down, so downstream consumers correctly treat metadata as modified when statistics cannot be used.

What changed

  • Added a new boolean field dataTypeModifiedAndCannotUseStatistics to:
    • TimeseriesMetadata
    • ChunkMetadata
  • Added accessor/mutator methods for the new flag to:
    • ITimeSeriesMetadata (interface)
    • IChunkMetadata (interface)
  • Implemented propagation and usage:
    • TimeseriesMetadata.getCopiedChunkMetadataList now copies the dataTypeModifiedAndCannotUseStatistics flag into copied ChunkMetadata instances.
    • TimeseriesMetadata.isModified and ChunkMetadata.isModified now return true if either the existing modified flag or dataTypeModifiedAndCannotUseStatistics is true.
    • ChunkMetadata.setDataTypeModifiedAndCannotUseStatistics and TimeseriesMetadata.setDataTypeModifiedAndCannotUseStatistics use |= semantics to accumulate the flag (preserve any previous true).
    • AbstractAlignedChunkMetadata and AbstractAlignedTimeSeriesMetadata delegate the new getter/setter to their underlying time/timeseries metadata objects so aligned metadata also exposes and propagates the flag.

@JackieTien97 JackieTien97 merged commit 052ff6b into apache:develop Feb 6, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants