Remove check for project when creating new account for ICLA #266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebbASF
requested changes
Mar 19, 2025
Contributor
sebbASF
left a comment
sebbASF
left a comment
There was a problem hiding this comment.
AFAICT that does not solve the issue; the project is still required if a user is provided.
Also, if the project is provided, but is not valid, surely the form should not be considered valid?
There's more work to be done (and testing).
noelportillo
previously approved these changes
Jun 15, 2025
Contributor
Author
|
There are cases that need to be addressed:
|
Contributor
|
AFAICT if a user id is not provided, then the project name is not necessary, so there is a work-round, albeit not always as convenient. Given that notification needs to be sent somewhere when such a request is made, perhaps it would make more sense to allow for some extra 'projects' in the list, so the target of the email can be established? |
noelportillo
previously approved these changes
Aug 10, 2025
noelportillo
previously approved these changes
Aug 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current ICLA handling for new accounts requires the project be valid. This causes an issue for new members who do not have an account and thus have no project.
All other checks are left in place.