Some ASCII-safe constants as byte[] to obviate ASCII-check#249
Open
DanskerDave wants to merge 1 commit intoapache:masterfrom
Open
Some ASCII-safe constants as byte[] to obviate ASCII-check#249DanskerDave wants to merge 1 commit intoapache:masterfrom
DanskerDave wants to merge 1 commit intoapache:masterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #249 +/- ##
==========================================
+ Coverage 58.52% 58.54% +0.02%
==========================================
Files 515 515
Lines 14794 14807 +13
Branches 2553 2555 +2
==========================================
+ Hits 8658 8669 +11
- Misses 5539 5540 +1
- Partials 597 598 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Is this change motivated by profiling, i.e. does it address an actual performance issue? |
Author
Well, it will make it a tad faster, by not checking that Strings known to be pure ASCII, really are ASCII. Having them compiled as byte[] will save a bit too. My Climate-Change contribution to save the planet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.