-
Notifications
You must be signed in to change notification settings - Fork 72
Upgrade Node.js 20 → 22 #2040
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Node.js 20 → 22 #2040
Conversation
|
@copilot please use correct types instead of |
|
@copilot please also use nodejs version 22.18.0 |
Replaced Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
@copilot do not use |
Co-authored-by: dcroote <13989647+dcroote@users.noreply.github.com>
Updated Node.js version to 22.18.0 across all configuration files and Docker images. Commit: df579c0 Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Fixed the type incompatibility properly:
Commit: 8a645a4 Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
dcroote
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Siegrift - I've reviewed and it looks good. The update was actually more straightforward than I expected, though perhaps I am still scarred from the pain of #1920. Copilot forgot a couple things that I needed to fix.
Copilot's attempt before this (#2039) was very frustrating (just read the comments, it couldn't even push its own changes to its own branch), and this PR was not a pleasant experience either, so I probably won't be using it again any time soon. Hopefully over time these pain points will get resolved.
|
|
||
| commandSpinner.succeed(`Finished command '${command}' with options ${stringifiedOptions}`); | ||
| return goExec.data.stdout; | ||
| return goExec.data.stdout.toString(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor node.js 22 update as the data.stdout type is stdout: string | NonSharedBuffer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dirent caused issues in the 20 -> 22 conversion, and I simultaneously wanted to see if copilot, when forced, could get the typing figured out without the use of as unknown or any and seems like it has.
Siegrift
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM
Node.js 20 to 22 Upgrade ✅
This PR upgrades Node.js from version 20 to version 22 across the entire Airnode repository.
Changes:
typeof fs.readdirSyncVerification:
Security Summary:
No security vulnerabilities were found in the code changes. The upgrade is safe to merge.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.