-
Notifications
You must be signed in to change notification settings - Fork 161
feat: add https proxy server implementation #626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
jirimoravcik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, looks great, had a few comments
tobice
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly I have no idea how proxy-chain works and my general knowledge of proxies is still limited 😄 So I'm leaving the actual functionality review to Jirka and Ludvík.
From my PoV the application code change is small, well documented and easy to read. No concerns there.
The tests, especially the new ones, would benefit from splitting into files. Also one scenario caught my attention due to its nested structure. I'm not sure why that's needed.
Finally, I'd expand on the PR description. You can e.g. add there the nice diagram from the original PR.
This PR represents simplification of #602. It contains changes related only to HTTPS proxy server support.
Scope:
Out Of Scope (should be fixed separately):
got-scrapting.Note: I might miss some edge cases for HTTPS server proxy, however I think that current coverage is good enough and covers core logic fully (80/20) and is backward compatible (HTTP proxy server tests pass).