Open
Conversation
github-actions
bot
added
t-infra
MrkMrk00
force-pushed
the
feat/composite-action-signed-commit
branch
from
f5ef045 to
b49bc3f
Compare
MrkMrk00
force-pushed
the
feat/composite-action-signed-commit
branch
from
59267de to
b754f0a
Compare
There was a problem hiding this comment.
Pull request overview
This PR introduces a new composite GitHub Action for creating commits via the GitHub GraphQL API (intended to produce verified/signed commits), and adds Node/TypeScript/Jest tooling plus a local workflow to lint and test GitHub Actions code.
Changes:
- Added
.github/actions/commitcomposite action and its JS implementation + Jest test. - Added repo-level Node toolchain files (
package.json,package-lock.json,tsconfig.json) to typecheck JS and run Jest. - Replaced the local workflow lint entrypoint with a new workflow that also runs typecheck/tests.
Reviewed changes
Copilot reviewed 6 out of 9 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
tsconfig.json |
Adds TypeScript config to typecheck .github/actions/**/*.js. |
package.json |
Adds devDependencies for TypeScript/Jest and action-related types. |
package-lock.json |
Locks the Node dependency tree for the new tooling. |
.gitignore |
Ignores node_modules/ created by the new tooling. |
.github/workflows/local_lint_gh_actions.yaml |
Removes the prior local lint workflow entrypoint. |
.github/workflows/local_lint.yaml |
Adds a local workflow that lints actions and runs tsc + jest. |
.github/actions/commit/index.js |
Implements staging diff + createCommitOnBranch GraphQL mutation. |
.github/actions/commit/index.test.js |
Adds a Jest test for the staged-file diffing logic. |
.github/actions/commit/action.yml |
Defines the composite action that wires github-script to index.js. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
MrkMrk00
force-pushed
the
feat/composite-action-signed-commit
branch
from
bb0b5c5 to
4b22c61
Compare
fnesveda
requested changes
Mar 30, 2026
Member
fnesveda
left a comment
fnesveda
left a comment
There was a problem hiding this comment.
Looks good, just a few points 🙂 But I hope this won't grow into a behemoth we'll have maintain too intensely 😄
| @@ -0,0 +1,19 @@ | |||
| { | |||
Member
There was a problem hiding this comment.
Can we please use @apify/tsconfig as the base?
MrkMrk00
force-pushed
the
feat/composite-action-signed-commit
branch
from
26407ed to
3654d94
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR re-implements the reusable workflow from #260 as a composite action.
It also add some basic tests of the action.
Tested by copy-pasting into: https://github.com/apify/hub/actions/runs/23737116236/job/69144551353#step:9:4