Merged
Conversation
…atic/core-lib-php into feat-signature-verification
|
There was a problem hiding this comment.
Pull Request Overview
This PR introduces HMAC signature verification functionality to the Core library, along with a utility for extracting values from JSON using JSON Pointer notation. The implementation includes comprehensive test coverage and refactors existing JSON pointer logic into a reusable utility class.
Key changes:
- Adds HMAC signature verification with configurable algorithms, encoding schemes, and signature templates
- Extracts JSON pointer functionality into a reusable utility class
- Adds Symfony HTTP Foundation dependency for request handling
Reviewed Changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/SignatureVerifier/HmacSignatureVerifier.php | Core implementation of HMAC signature verification with support for multiple algorithms and encoding formats |
| src/SignatureVerifier/SignatureVerifierInterface.php | Interface defining the contract for signature verification implementations |
| src/SignatureVerifier/VerificationFailure.php | Simple value object for representing verification failures with error messages |
| src/Utils/JsonPointerValue.php | Utility class for extracting values from JSON strings using JSON Pointer paths |
| src/Response/Types/ErrorType.php | Refactored to use the new JsonPointerValue utility instead of duplicated implementation |
| tests/SignatureVerifierTest.php | Comprehensive test suite covering HMAC verification scenarios including edge cases and multiple encoding formats |
| tests/Mocking/SignatureVerifier/MockVerificationFailure.php | Test mock extending VerificationFailure for use in signature verification tests |
| tests/JsonPointerValueTest.php | Complete test coverage for JSON pointer value extraction including edge cases |
| composer.json | Adds symfony/http-foundation dependency and reformats autoload configuration |
| .phan/config.php | Updates static analysis configuration to include Symfony HTTP Foundation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
asadali214
approved these changes
Nov 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What
This PR introduces HMAC signature verification functionality to the Core library, along with a utility for extracting values from JSON using JSON Pointer notation. The implementation includes comprehensive test coverage and refactors existing JSON pointer logic into a reusable utility class.
Key changes:
Why
To add the support of HMAC signature verification
Type of change
Select multiple if applicable.
Dependency Change
N/A
Breaking change
N/A
Testing
Unit tests are included in the PR for the new feature
Checklist