Reuse XPC connections across container operations#849
Closed
realrajaryan wants to merge 1 commit intoapple:mainfrom
Closed
Reuse XPC connections across container operations#849realrajaryan wants to merge 1 commit intoapple:mainfrom
realrajaryan wants to merge 1 commit intoapple:mainfrom
Conversation
jglogan
reviewed
Nov 18, 2025
| } | ||
|
|
||
| init(snapshot: ContainerSnapshot) { | ||
| public init(snapshot: ContainerSnapshot, xpcClient: XPCClient? = nil) { |
Contributor
There was a problem hiding this comment.
Having the caller provide a snapshot to a public method feels a little strange. I'd expect them to be able to create a ClientContainer using just a container ID.
Since we're now using snapshot as the return type for everything, do we really need to store configuration, status, and networks between calls?
Member
|
Closed via #1139 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Motivation and Context
Currently,
ClientContaineris overloaded, it's used for both data (during list(), you get given a ClientContainer) and to talk to the daemon. Each container operation creates a new XPC connection, which is pretty wasteful e.g.container stop --allwith 10 containers creates 11 XPC connections (1 for list and 10 for individual stops)To address this
list(),get(), andcreate()will now returnContainerSnapshotinstead ofClientContainer, andClientContainernow accepts an optionalXPCClientparameter for connection reuse so multiple operations can share the same connection. Commands that perform bulk operations now create a single sharedXPCClientand pass it to allClientContainerinstancesTesting