Disk io feature#954
Conversation
…atie's security recommendations
af5432e to
24599bd
Compare
| let estimatedReadOps = Double(totalReadBytes) / 4096.0 | ||
| let estimatedWriteOps = Double(totalWriteBytes) / 4096.0 | ||
|
|
||
| // TODO: Collect latency metrics from Containerization framework |
There was a problem hiding this comment.
I don't think we want to accept this until we actually have the stats to report.
There was a problem hiding this comment.
@dcantah should i close the whole pr or should i fix the code particualr code ?
There was a problem hiding this comment.
Well, fixing the code requires some Containerization changes to actually get these stats in some form. I think we'd want to think about what to actually expose, how expensive it is to grab them etc. I'd probably just make this PR a draft for now
There was a problem hiding this comment.
Well, fixing the code requires some Containerization changes to actually get these stats in some form. I think we'd want to think about what to actually expose, how expensive it is to grab them etc. I'd probably just make this PR a draft for now
For sure I'll make this draft and look into containerization repo and see where can we fix this
Type of Change
Motivation and Context
Closes #950
Apple Container currently lacks detailed per-container filesystem performance metrics (IOPS, latency, fsync frequency, queue depth, storage backend type), making it difficult to diagnose I/O bottlenecks in database workloads, build systems, and ML pipelines.
The fix:
Add
--ioflag tocontainer statscommand that displays detailed filesystem performance metrics:Testing