refactor memory alignment to VZVirtualMachineInstance#725
Open
yibozhuang wants to merge 1 commit intoapple:mainfrom
Open
refactor memory alignment to VZVirtualMachineInstance#725yibozhuang wants to merge 1 commit intoapple:mainfrom
yibozhuang wants to merge 1 commit intoapple:mainfrom
Conversation
dcantah
reviewed
May 5, 2026
dcantah
approved these changes
May 5, 2026
Move the MiB rounding from LinuxContainer into VZVirtualMachineInstance.toVZ(), so all callers are covered in one place and the alignment constraint stays with the VMM layer that owns it. This will also ensure LinuxPod can get memory alignment for free.
yibozhuang
force-pushed
the
linux-pod-memory-rounding
branch
from
ea46526 to
f1eb96d
Compare
yibozhuang
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the MiB rounding from LinuxContainer into
VZVirtualMachineInstance, so all callers are covered in one place and the alignment constraint stays with the VMM layer that owns it.This will also ensure LinuxPod can get memory alignment for free.