LinuxContainer/LinuxPod: Add ID length restriction#733
Open
dcantah wants to merge 1 commit intoapple:mainfrom
Open
LinuxContainer/LinuxPod: Add ID length restriction#733dcantah wants to merge 1 commit intoapple:mainfrom
dcantah wants to merge 1 commit intoapple:mainfrom
Conversation
I think realistically we should have a limit on this. Technically today the ID length restriction is whatever our grpc buffer length is.. I think 64 is long enough so that folks could use an entire hex based sha256, any uuid, and also sethostname has a length restriction of 64 anyways.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think realistically we should have a limit on this. Technically today the ID length restriction is whatever our grpc buffer length is..
I think 64 is long enough so that folks could use an entire hex based sha256, any uuid, and also sethostname has a length restriction of 64 anyways.