Add regression test for length-1 tensor int casts#2662
Open
hayeah wants to merge 1 commit intoapple:mainfrom
Open
Add regression test for length-1 tensor int casts#2662hayeah wants to merge 1 commit intoapple:mainfrom
hayeah wants to merge 1 commit intoapple:mainfrom
Conversation
Collaborator
|
Your unit test passes for me with the 9.0 release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
int()on a foldable length-1 tensorcoremltools 9.0Context
The released
9.0converter fails on traced Torch graphs that containaten::Intover a foldable length-1 tensor, for example a model that reshapes withint(h * w)after unpackingx.shape. Currentmainalready handles this correctly in_cast; this test locks that behavior in.Minimal repro shape pattern:
I verified locally that:
coremltools 9.0fails on this pattern withTypeError: only 0-dimensional arrays can be converted to Python scalarsmainconverts it successfully