Skip to content

fix(metrics): don't define duplicate port for metrics endpoint #1125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kodiak-appscode merged 1 commit into from
Jan 20, 2026
+2 −10
Merged

fix(metrics): don't define duplicate port for metrics endpoint #1125

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/ace/Chart.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,4 +39,4 @@ dependencies:
repository: file://../platform-opscenter
version: v2026.1.15
digest: sha256:7dfceb7b148a69deda78c4b0b52682e1bb85e72f98791174dc535762ad8aadc2
generated: "2026-01-07T09:47:09.959432+06:00"
generated: "2026-01-20T21:39:34.783116045+06:00"
8 changes: 0 additions & 8 deletions charts/platform-api/templates/service.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,6 @@ spec:
targetPort: http
protocol: TCP
name: http
- port: {{ .Values.service.port }}
targetPort: http
protocol: TCP
name: metrics
selector:
{{- include "platform-api.selectorLabels" . | nindent 4 }}

Expand All @@ -37,10 +33,6 @@ spec:
targetPort: http
protocol: TCP
name: http
- port: {{ .Values.service.port }}
targetPort: http
protocol: TCP
name: metrics
# selector needed to create pods dns name
selector:
{{- include "platform-api.selectorLabels" . | nindent 4 }}
2 changes: 1 addition & 1 deletion charts/platform-api/templates/servicemonitor.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,6 @@ spec:
{{- include "platform-api.selectorLabels" . | nindent 6 }}
endpoints:
- path: /metrics
port: metrics
port: http
scheme: http
{{- end }}