Skip to content

fix: make project limit alert program-aware #2850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HarshMN2345 merged 1 commit into from
Feb 11, 2026
Merged

fix: make project limit alert program-aware #2850

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/routes/(console)/organization-[organization]/+page.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,11 +219,11 @@
</Alert.Inline>
{/if}

{#if isCloud && data.currentPlan?.projects !== 0 && projectsToArchive.length === 0 && !freePlanAlertDismissed}
{#if isCloud && !data.program && data.currentPlan?.projects !== 0 && projectsToArchive.length === 0 && !freePlanAlertDismissed}
<Alert.Inline dismissible on:dismiss={dismissFreePlanAlert}>
<Typography.Text
>Your Free plan includes up to 2 projects and limited resources. Upgrade to unlock
more capacity and features.</Typography.Text>
>Your Free plan includes up to {data.currentPlan?.projects} projects and limited resources.
Upgrade to unlock more capacity and features.</Typography.Text>
Comment on lines +222 to +226
Copy link
Contributor

@coderabbitai coderabbitai bot Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Minor: undefined !== 0 is true — the guard doesn't protect against a missing currentPlan.

If data.currentPlan were ever null/undefined, the check data.currentPlan?.projects !== 0 evaluates to undefined !== 0 → true, so the alert would render with the text "up to undefined projects". This is likely safe in practice (cloud layouts should always load currentPlan), but a small tweak makes it more robust:

Suggested defensive tweak 
-    {`#if` isCloud && !data.program && data.currentPlan?.projects !== 0 && projectsToArchive.length === 0 && !freePlanAlertDismissed}
+    {`#if` isCloud && !data.program && data.currentPlan?.projects && projectsToArchive.length === 0 && !freePlanAlertDismissed}

Using truthiness (data.currentPlan?.projects is falsy for both 0 and undefined/null) collapses the two failure modes into one check and avoids rendering "undefined" in the message.

🤖 Prompt for AI Agents 
In `@src/routes/`(console)/organization-[organization]/+page.svelte around lines
222 - 226, The conditional renders an alert when data.currentPlan may be
undefined because `data.currentPlan?.projects !== 0` is true for undefined;
change the guard to ensure projects is present and non-zero (e.g., check
`data.currentPlan?.projects` truthiness or explicitly
`data.currentPlan?.projects > 0`) so the Alert.Inline/Tyography.Text never shows
"up to undefined projects"; update the condition in the same expression that
uses isCloud, data.currentPlan?.projects, projectsToArchive.length,
freePlanAlertDismissed and keep dismissFreePlanAlert behavior unchanged.

<svelte:fragment slot="actions">
<Button
compact
Expand Down