Skip to content

Conversation

@ItzNotABug
Copy link
Member

@ItzNotABug ItzNotABug commented Jan 17, 2026

What does this PR do?

Adds changelog entry and resource updates related to execution log retention based on plans.

Test Plan

Manual.

Related PRs and Issues

N/A.

Have you read the Contributing Guidelines on issues?

Yes.

Summary by CodeRabbit

  • New Features

    • Added execution logs retention limit to pricing plan comparison: 100 logs for free tier, 1,000 for pro tier, unlimited for scale tier, and custom limits for enterprise tier.
  • Bug Fixes

    • Improved platform handling in non-browser environments.
  • Chores

    • Updated build infrastructure and development tools.

✏️ Tip: You can customize this high-level summary in your review settings.

@ItzNotABug ItzNotABug self-assigned this Jan 17, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 17, 2026

Walkthrough

This pull request includes five localized changes across different parts of the codebase: adding a caching flag to the Prettier formatting script, introducing browser environment guards in the references utility to handle non-browser contexts, updating a Svelte template's list key generation to include index values, adding an "Execution logs" row to the pricing comparison table, and updating CI workflow configurations to use the latest bun version instead of 1.3. All changes are isolated to their respective scopes without altering export declarations or control flow patterns.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title mentions 'changelog and plan changes' which aligns with the actual changes: a changelog entry addition and updates to pricing/plan resources (execution logs row added to compare-plans.svelte).

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Fix all issues with AI agents
In `@src/routes/changelog/`(entries)/2026-01-19.markdoc:
- Around line 11-12: The changelog wording ("100 execution logs per
function/site" / "1,000 execution logs per function/site") conflicts with the
pricing table's "/ month" phrasing; update the changelog entry in
2026-01-19.markdoc to explicitly state these are rolling retention limits (e.g.,
"maximum retained at any time (rolling retention): 100 execution logs per
function/site" and "1,000 execution logs per function/site") so it matches the
intent shown in compare-plans.svelte, or alternatively remove "/ month" from the
pricing table—pick one approach and make the wording consistent across
2026-01-19.markdoc and compare-plans.svelte.

In `@src/routes/pricing/compare-plans.svelte`:
- Around line 75-82: The plan entry titled "Execution logs" currently appends "/
month" to the free/pro values which conflicts with the info tooltip describing
rolling retention; update the object for the "Execution logs" entry by removing
the "/ month" suffix from the free and pro strings (and adjust scale/enterprise
if needed) so values reflect retained counts (e.g., "100", "1000", "Unlimited",
"Custom") and ensure the info text remains "Number of execution logs retained
per function/site".
🧹 Nitpick comments (1)
src/routes/(marketing)/(components)/pricing.svelte (1)

102-102: Consider simplifying the composite key.

Since name is already unique across all plans (Free, Pro, Scale, Enterprise), the composite key ${name},${label},${index} is redundant. Including index in the key can also reduce Svelte's ability to optimize DOM reuse when the list order changes.

Unless there's a specific reactivity issue this addresses, simplifying to just name would be cleaner:

-{`#each` visiblePlans as { name, price, tag: label, subtitle, description, event }, index (`${name},${label},${index}`)}
+{`#each` visiblePlans as { name, price, tag: label, subtitle, description, event } (name)}

Co-authored-by: Jake Barnby <jakeb994@gmail.com>
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@src/routes/changelog/`(entries)/2026-01-19.markdoc:
- Line 9: Replace the relative phrase "Starting today" in the changelog sentence
"Starting today, execution logs for functions and sites will be retained based
on your plan:" with an explicit date (use the entry date 2026-01-19) so the
sentence reads something like "As of 2026-01-19, execution logs for functions
and sites will be retained based on your plan:".

@ItzNotABug ItzNotABug merged commit a0213e6 into main Jan 20, 2026
10 of 11 checks passed
@ItzNotABug ItzNotABug deleted the fix-dat-1039 branch January 20, 2026 08:47
- uses: oven-sh/setup-bun@v2
with:
bun-version: 1.3
bun-version: latest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should still pin, just to whichever version works for our setup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants