Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request addresses an issue where the version badge was not updating correctly when there was a version mismatch between the README and the version specified in Solution.props.
- Added debug echo statements to help trace version and badge updates.
- Modified the logic to extract the current version and status from README badge URLs and added comparison checks to determine if an update is required.
Comments suppressed due to low confidence (2)
.github/actions/version-tools/action.yml:145
- The use of grep with the -P flag may not be supported in all environments. Consider confirming its compatibility or using an alternative approach to ensure consistent behavior.
CURRENT_VERSION_IN_BADGE=$(echo "$CURRENT_VERSION_BADGE" | grep -oP 'version-\K[^-]*(?=-|-)' | sed 's/%2E/./g' | sed 's/--/-/g')
.github/actions/version-tools/action.yml:169
- Similar to the version extraction, grep -oP is used here and may cause compatibility issues in some environments. Make sure the target CI environment supports this flag or consider an alternative solution.
CURRENT_STATUS_IN_BADGE=$(echo "$CURRENT_STATUS_BADGE" | grep -oP 'status-\K[^-]*(?=-)')
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.